Re: [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline

[Sedat Dilek]

On Tue, Jun 5, 2018 at 7:31 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> On 06/05/18 10:28, H. Peter Anvin wrote:
>> On 06/05/18 10:05, Nick Desaulniers wrote:
>>> +
>>> +/*
>>> + * void native_restore_fl(unsigned long flags)
>>> + * %rdi: flags
>>> + */
>>> +ENTRY(native_restore_fl)
>>> +    push %_ASM_DI
>>> +    popf
>>> +    ret
>>> +ENDPROC(native_restore_fl)
>>> +EXPORT_SYMBOL(native_restore_fl)
>>>
>>
>> To work on i386, this would have to be %_ASM_AX in that case.
>>
>> Something like this added to <asm/asm.h> might be useful; then you can
>> simply:
>>
>>       push %_ASM_ARG1
>>
>
> Version with fixed typo...

Small typo in the commit-subject... s/argument registes/argument registers

- sed@ -