Re: [PATCH v2 7/8] extcon: usbc-cros-ec: Switch to SPDX identifier.

[Dmitry Torokhov]

On Tue, Jun 5, 2018 at 11:15 AM, Benson Leung <bleung@xxxxxxxxxx> wrote:
> On Tue, Jun 05, 2018 at 07:54:28PM +0200, Enric Balletbo i Serra wrote:
>> Adopt the SPDX license identifier headers to ease license compliance
>> management.
>>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
>
> Reviewed-by: Benson Leung <bleung@xxxxxxxxxxxx>

It has wrong license tag, I think all ChromeOS drivers as GPL v2 only.

>
>> ---
>>
>> Changes in v2:
>> - [8/9] Fixed wrong copyright year.
>>
>>  drivers/extcon/extcon-usbc-cros-ec.c | 20 +++++---------------
>>  1 file changed, 5 insertions(+), 15 deletions(-)
>>
>> diff --git a/drivers/extcon/extcon-usbc-cros-ec.c b/drivers/extcon/extcon-usbc-cros-ec.c
>> index 6721ab01fe7d..ef5a23e46e71 100644
>> --- a/drivers/extcon/extcon-usbc-cros-ec.c
>> +++ b/drivers/extcon/extcon-usbc-cros-ec.c
>> @@ -1,18 +1,8 @@
>> -/**
>> - * drivers/extcon/extcon-usbc-cros-ec - ChromeOS Embedded Controller extcon
>> - *
>> - * Copyright (C) 2017 Google, Inc
>> - * Author: Benson Leung <bleung@xxxxxxxxxxxx>
>> - *
>> - * This software is licensed under the terms of the GNU General Public
>> - * License version 2, as published by the Free Software Foundation, and
>> - * may be copied, distributed, and modified under those terms.
>> - *
>> - * This program is distributed in the hope that it will be useful,
>> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> - * GNU General Public License for more details.
>> - */
>> +// SPDX-License-Identifier: GPL-2.0+
>> +// ChromeOS Embedded Controller extcon
>> +//
>> +// Copyright (C) 2017 Google, Inc.
>> +// Author: Benson Leung <bleung@xxxxxxxxxxxx>
>>
>>  #include <linux/extcon-provider.h>
>>  #include <linux/kernel.h>
>> --
>> 2.17.1
>>
>
> --
> Benson Leung
> Staff Software Engineer
> Chrome OS Kernel
> Google Inc.
> bleung@xxxxxxxxxx
> Chromium OS Project
> bleung@xxxxxxxxxxxx



-- 
Dmitry