Re: [PATCH v3] kbuild: check for pkg-config on make {menu,n,g.x}config
From: Randy Dunlap
Date: Tue Jun 05 2018 - 20:42:03 EST
On 06/04/2018 11:53 PM, Masahiro Yamada wrote:
> Hi Randy,
>
>
> 2018-06-04 11:59 GMT+09:00 Randy Dunlap <rdunlap@xxxxxxxxxxxxx>:
>> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>>
>> Each of 'make {menu,n,g,x}config' uses (needs) pkg-config to make sure
>> that other required files are present and to determine build flags
>> settings, but none of these check that pkg-config itself is present.
>> Add a check for all 4 of these targets and update
>> Documentation/process/changes.rst to mention 'pkg-config'.
>>
>> Fixes kernel bugzilla #77511:
>> https://bugzilla.kernel.org/show_bug.cgi?id=77511
>>
>> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>> Cc: BjÃrn Forsman <bjorn.forsman@xxxxxxxxx>
>> ---
>> Strictly speaking, pkg-config is not required if someone is only
>> using 'make {menu,n}config' since there are fallbacks for those
>> two targets.
>>
OK, I made your suggested changes and will test it later and then resend it.
thanks,
--
~Randy