Re: [PATCH V2 2/2] arm: dts: sunxi: Add missing cooling device properties for CPUs
From: Maxime Ripard
Date: Wed Jun 06 2018 - 02:58:28 EST
On Wed, Jun 06, 2018 at 12:02:20AM +0800, Chen-Yu Tsai wrote:
> On Tue, Jun 5, 2018 at 3:11 PM, Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote:
> > On Tue, Jun 05, 2018 at 10:17:49AM +0530, Viresh Kumar wrote:
> >> The cooling device properties, like "#cooling-cells" and
> >> "dynamic-power-coefficient", should either be present for all the CPUs
> >> of a cluster or none. If these are present only for a subset of CPUs of
> >> a cluster then things will start falling apart as soon as the CPUs are
> >> brought online in a different order. For example, this will happen
> >> because the operating system looks for such properties in the CPU node
> >> it is trying to bring up, so that it can register a cooling device.
> >> Add such missing properties.
> >> Fix other missing properties (clocks, OPP, clock latency) as well to
> >> make it all work.
> >> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> > Applied both, thanks!
> Please fix the "ARM" prefix when applying. :)
Done, thanks for the reminder :)
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
Description: PGP signature