Re: [PATCH] selftests/ftrace: Add ppc support for kprobe args tests

[Masami Hiramatsu]

On Wed,  6 Jun 2018 15:01:54 +0530
"Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxxxxxxx> wrote:

> Add powerpc support for the recently added kprobe args tests.

Thank you for adding powerpc support!

Reviewed-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

> 
> Signed-off-by: Naveen N. Rao <naveen.n.rao@xxxxxxxxxxxxxxxxxx>
> ---
>  .../selftests/ftrace/test.d/kprobe/kprobe_args_string.tc  | 8 ++++++++
>  .../selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc  | 7 +++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> index 5ba73035e1d9..a0002563e9ee 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> @@ -24,6 +24,14 @@ arm*)
>    ARG2=%r1
>    OFFS=4
>  ;;
> +ppc64*)
> +  ARG2=%r4
> +  OFFS=8
> +;;
> +ppc*)
> +  ARG2=%r4
> +  OFFS=4
> +;;
>  *)
>    echo "Please implement other architecture here"
>    exit_untested
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> index 231bcd2c4eb5..d026ff4e562f 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> @@ -34,6 +34,13 @@ arm*)
>    GOODREG=%r0
>    BADREG=%ax
>  ;;
> +ppc*)
> +  GOODREG=%r3
> +  BADREG=%msr
> +;;
> +*)
> +  echo "Please implement other architecture here"
> +  exit_untested
>  esac
>  
>  test_goodarg() # Good-args
> -- 
> 2.17.0
> 


-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>