unnecessary tests?
From: Julia Lawall
Date: Wed Jun 06 2018 - 08:42:18 EST
In the file drivers/media/tuners/mxl5005s.c, the function MXL_BlockInit
contains:
status += MXL_ControlWrite(fe,
RFSYN_EN_CHP_HIGAIN, state->Mode ? 1 : 1);
status += MXL_ControlWrite(fe, EN_CHP_LIN_B, state->Mode ? 0 : 0);
Could the second arguments just be 1 and 0, respectively? It's true that
the preceeding call contains state->Mode, but in a more useful way, so
perhaps it could be useful for uniformity?
thanks,
julia