Re: [PATCH] ARM: dts: cygnus: Add HWRNG node
From: Florian Fainelli
Date: Wed Jun 06 2018 - 12:47:32 EST
On 06/06/2018 09:03 AM, Scott Branden wrote:
> Hi Clement,
>
>
> On 18-06-06 02:34 AM, ClÃment PÃron wrote:
>> From: ClÃment Peron <clement.peron@xxxxxxxxxxxx>
>>
>> There is a HWRNG in Broadcom Cygnus SoC, so enable it.
>>
>> Signed-off-by: ClÃment Peron <clement.peron@xxxxxxxxxxxx>
> Thanks for upstreaming some missing Cygnus components.
>
> But, the problem is the tarball release from Broadcom you are extracting
> these changes from does not contain git history; so, you are missing the
> original authors and signed-off's.
> I checked our internal git repository and for this commit the author is:
> Mohamed Ismail Abdul Packir Mohamed <mohamed-ismail.abdul@xxxxxxxxxxxx>
>
> Please adjust author and signed-off appropriately. If there are other
> changes you are extracting from the source tarballs you have please
> contact me so we can construct patch appropriately.
If you want the original author's Signed-off-by to be preserved, why
don't you extract it from your internal git tree and submit the patch on
Mohamed's behalf?
AFAICT what Clement is doing here is permissible given the Linux
developer certificate of origin though I am not a lawyer of course.
--
Florian