Re: [PATCH] ARM: dts: cygnus: Add HWRNG node

From: Scott Branden
Date: Wed Jun 06 2018 - 13:14:28 EST




On 18-06-06 09:47 AM, Florian Fainelli wrote:
On 06/06/2018 09:03 AM, Scott Branden wrote:
Hi Clement,


On 18-06-06 02:34 AM, ClÃment PÃron wrote:
From: ClÃment Peron <clement.peron@xxxxxxxxxxxx>

There is a HWRNG in Broadcom Cygnus SoC, so enable it.

Signed-off-by: ClÃment Peron <clement.peron@xxxxxxxxxxxx>
Thanks for upstreaming some missing Cygnus components.

But, the problem is the tarball release from Broadcom you are extracting
these changes from does not contain git history; so, you are missing the
original authors and signed-off's.
I checked our internal git repository and for this commit the author is:
Mohamed Ismail Abdul Packir Mohamed <mohamed-ismail.abdul@xxxxxxxxxxxx>

Please adjust author and signed-off appropriately. If there are other
changes you are extracting from the source tarballs you have please
contact me so we can construct patch appropriately.
If you want the original author's Signed-off-by to be preserved, why
don't you extract it from your internal git tree and submit the patch on
Mohamed's behalf?
Sure, I can submit the original patch to keep things simple and avoid finding a lawyer right now.

AFAICT what Clement is doing here is permissible given the Linux
developer certificate of origin though I am not a lawyer of course.
But, It would be great to get some guidance and clarification on this for sure.
I'm reading:
https://www.kernel.org/doc/html/v4.16/process/submitting-patches.html

The change was created entirely by Broadcom, so seems difficult for somebody else to upstream change without appropriate authorship and signed off from copyright holder. Point a) and b) are not met in Developer's Certificate of Origin while point c) is being attempted (without a or b being certified).