Re: [PATCH] bnx2x: use the right constant
From: David Miller
Date: Wed Jun 06 2018 - 14:01:47 EST
From: Julia Lawall <Julia.Lawall@xxxxxxx>
Date: Wed, 6 Jun 2018 15:03:22 +0200
> Nearby code that also tests port suggests that the P0 constant should be
> used when port is zero.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e,e1;
> @@
>
> * e ? e1 : e1
> // </smpl>
>
> Fixes: 6c3218c6f7e5 ("bnx2x: Adjust ETS to 578xx")
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
This definitely looks correct. Applied and queued up for -stable, thanks!