[PATCH 3.16 067/410] EDAC, octeon: Fix an uninitialized variable warning

From: Ben Hutchings
Date: Thu Jun 07 2018 - 11:01:37 EST


3.16.57-rc1 review patch. If anyone has any objections, please let me know.

------------------

From: James Hogan <jhogan@xxxxxxxxxx>

commit 544e92581a2ac44607d7cc602c6b54d18656f56d upstream.

Fix an uninitialized variable warning in the Octeon EDAC driver, as seen
in MIPS cavium_octeon_defconfig builds since v4.14 with Codescape GNU
Tools 2016.05-03:

drivers/edac/octeon_edac-lmc.c In function âocteon_lmc_edac_poll_o2â:
drivers/edac/octeon_edac-lmc.c:87:24: warning: â((long unsigned int*)&int_reg)[1]â may \
be used uninitialized in this function [-Wmaybe-uninitialized]
if (int_reg.s.sec_err || int_reg.s.ded_err) {
^
Iinitialise the whole int_reg variable to zero before the conditional
assignments in the error injection case.

Signed-off-by: James Hogan <jhogan@xxxxxxxxxx>
Acked-by: David Daney <david.daney@xxxxxxxxxx>
Cc: linux-edac <linux-edac@xxxxxxxxxxxxxxx>
Cc: linux-mips@xxxxxxxxxxxxxx
Fixes: 1bc021e81565 ("EDAC: Octeon: Add error injection support")
Link: http://lkml.kernel.org/r/20171113161206.20990-1-james.hogan@xxxxxxxx
Signed-off-by: Borislav Petkov <bp@xxxxxxx>
Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
---
drivers/edac/octeon_edac-lmc.c | 1 +
1 file changed, 1 insertion(+)

--- a/drivers/edac/octeon_edac-lmc.c
+++ b/drivers/edac/octeon_edac-lmc.c
@@ -79,6 +79,7 @@ static void octeon_lmc_edac_poll_o2(stru
if (!pvt->inject)
int_reg.u64 = cvmx_read_csr(CVMX_LMCX_INT(mci->mc_idx));
else {
+ int_reg.u64 = 0;
if (pvt->error_type == 1)
int_reg.s.sec_err = 1;
if (pvt->error_type == 2)