Re: [PATCH 1/2] ARM: dts: imx6qdl-sabreauto: Add sensors

From: Fabio Estevam
Date: Thu Jun 07 2018 - 13:07:59 EST


Hi Leonard,

On Thu, Jun 7, 2018 at 2:00 PM, Leonard Crestez <leonard.crestez@xxxxxxx> wrote:

> +
> + isl29023@44 {

According to Devicetree Specification v0.2 document:

"The name of a node should be somewhat generic, reflecting the function
of the device and not its precise programming model."

So you could write:

light-sensor@44


> + compatible = "isil,isl29023";
> + reg = <0x44>;
> + interrupt-parent = <&gpio5>;
> + interrupts = <17 IRQ_TYPE_EDGE_FALLING>;
> + };
> +
> + mag3110@0e {

No leading zero in unit address, please.

Building with W=1 will give you warnings about it.

magnetometer@e

> + compatible = "fsl,mag3110";
> + reg = <0x0e>;
> + interrupt-parent = <&gpio2>;
> + interrupts = <29 IRQ_TYPE_EDGE_RISING>;
> + };
> +
> + mma8451@1c {

accelerometer@1c