Re: [PATCH v5 21/31] kconfig: show compiler version text in the top comment

[Geert Uytterhoeven]

Hi Yamada-san,

On Fri, Jun 8, 2018 at 9:04 AM, Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
> 2018-06-07 17:58 GMT+09:00 Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>:
>> 2018-06-07 17:42 GMT+09:00 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>:
>>> On Mon, May 28, 2018 at 11:21 AM, Masahiro Yamada
>>> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
>>>> The kernel configuration phase is now tightly coupled with the compiler
>>>> in use.  It will be nice to show the compiler information in Kconfig.

[...]

>>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>>>> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
>>>
>>> This is now commit 21c54b774744719c ("kconfig: show compiler version text
>>> in the top comment") upstream.
>>>
>>> This commit broke cross-compilation for me:
>>>
>>>     $ make ARCH=m68k
>>>     scripts/kconfig/conf  --syncconfig Kconfig
>>>     scripts/kconfig/conf  --syncconfig Kconfig
>>>     scripts/kconfig/conf  --syncconfig Kconfig
>>>     scripts/kconfig/conf  --syncconfig Kconfig
>>>     ...
>>>
>>> with O=:
>>>
>>>       GEN     ./Makefile
>>>      scripts/kconfig/conf  --syncconfig Kconfig
>>>       GEN     ./Makefile
>>>     scripts/kconfig/conf  --syncconfig Kconfig
>>>       GEN     ./Makefile
>>>     scripts/kconfig/conf  --syncconfig Kconfig
>>>       GEN     ./Makefile
>>>     ...
>>>
>>> .config gained (both with/without O=):
>>>
>>>     #
>>>     # Compiler: gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
>>>     #
>>>
>>> which is definitely wrong when cross-compiling for m68k.
>>>
>>> Reverting the commit, and fixing up the conflicts, fixes the issue for me
>>>
>>> Do you have a clue?
>>> Thanks!
>>
>>
>> Agh, I missed the case where CROSS_COMPILE is
>> set by arch/$(SRCARCH)/Makefile.
>>
>>
>> I will fix it.  Thanks for the report!
>
> I posted a patch.
> https://patchwork.kernel.org/patch/10453685/
>
> I hope it will fix your problem.

Yes it has. Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds