Re: [PATCH v1 09/13] PCI/AER: Move aer_irq() declaration to portdrv.h

From: Keith Busch
Date: Fri Jun 08 2018 - 16:14:31 EST


On Fri, Jun 08, 2018 at 03:05:41PM -0500, Bjorn Helgaas wrote:
> The aer_irq() declaration is the only thing needed by aer_inject.c. Move
> it to portdrv.h so we eventually get rid of aerdrv.h completely. No
> functional change intended.

Nothing against what you're doing here, but it does seem odd that aer_irq
is required to be exported just for the error injection to directly call
it. I feel like aer-inject should route it through the irq subsystem,
like with generic_handle_irq. ?