Re: [PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change

[Hans de Goede]

Hi,

On 09-06-18 02:33, Darren Hart wrote:
> On Wed, Jun 06, 2018 at 05:32:52PM +0200, Hans de Goede wrote:
>
> > > > > > If we are adding hwdb entries anyway to control the userspace
> > > > > > interpretation of the TOGGLE key, then we could also add the new CYCLE
> > > > > > key and explicitly re-map it to TOGGLE. That requires slightly more
> > > > > > logic in hwdb, but it does mean that we could theoretically just drop
> > > > > > the workaround if we ever stop caring about Xorg.
> > > > >
> > > > > Hmm, interesting proposal, I say go for it :)
> > > >
> > > > So maybe the next stop is that I can follow Darren's suggestion to eliminate
> > > > the is_kbd_led_event() and send a v2 for review?
> > >
> > > I believe the best compromise we have right now is to do what Hans
> > > suggested in an earlier proposal. That is implementing the two separate
> > > behaviours in the kernel
> > >
> > >    1) handle this in the kernel as if the hardware changed it, and
> > >    2) send a new KEY_KBDILLUMCYCLE event [default].
> >
> > I think you mean or, not and, depending on a module option the
> > code should do either 1) or 2) not both :)
> >
> > Darren, Andy could you live with a module option for this?
>
> We are of course strongly opposed to adding module options.
>
> I agree we can't ignore Xorg.
>
> I agree policy in general should not be in the kernel.
>
> I also see many of these drivers as the last mile to getting a platform
> fully working. If there is a place for one-off fixes, it's in these
> drivers. I'd love to refactor and use proper abstractions and all that
> as the patterns make those abstractions clear - but I don't want to
> delay getting something working waiting for the ideal solution.
>
> So I have two questions I'd like to confirm before saying "OK" to a
> module option.
>
> 1) Hans I think you said that doing the code conversion from TOGGLE to
> UP based on the LED value and the max value was racy with userspace.
> What is the failure mode here? Is it not easily recoverable? And how do
> I enter it?

g-s-d can currently already auto-dim the brightness of the
kbd backlight when idle (if there are enough brightness levels).

Lets say that the brightness is at its highest setting and the user
wants to cycle the backlight to off.

But just before the user hits the cycle key, the timeout expires
and userspace dimms the backlight, now the kernel processes
the cycle key event, sees it is not max and sends an up, instead
of the expected toggle.

Note we already have this problem on machines where the cycle
behavior is implemented in the firmware/hardware rather then
inside the kernel.

A bigger problem with sending up-up-up-toggle is that g-s-d saves
the current brightness (max) on the first toggle and restores that
on the second toggle, so the second up-up-up-toggle sequence we
end up restoring the max, going from max to max on the toggle.

So the user needs to press toggle twice at max brightness to get
to off (and then once for the next cycle, then 2 times again for
the cycle after that, etc.).

So I think it is fair to say that sending up-up-up-toggle is not a
good idea.

> Do I have to simultaneously modify the software brightness
> control AND press the keyboard brightness control? How practical is
> that? If recoverable AND hard to trigger, I think there is value in the
> very simple 3 level brightness cycle being handled in the kernel.
>
> 2) Why is a module option preferable to a compile time option? It seems
> to me the policy will be largely distro dependent, and the same kernel
> needing to support both modes seems likely to be pretty rare.

Because lets say that we have everything in place in a recent Fedora
to handle the cycle-key in userspace, so we have a mapping for the
new event at all levels and g-s-d code to handle it. Then this will
still only work for GNOME3 and possibly other wayland based desktop
environments. While some of our users will keep using the X11 based
XFCE or mate desktop environments.

So what we actually want is a module option, with a configurable
default. So that we can make the default send the cycle event in
a future Fedora, while XFCE / mate users can override the default
using the module option.

###

So typing all of the above has made me think about this once more.

Specifically about how most popular brands handle the cycle behavior
in firmware/hardware already and that userspace already needs to
deal with this and that sofar this does not seem to be a problem.

Combine this with the ugliness of adding a module option +
adding a new cycle input event requiring a lot of work at various
layers to actually work and I think that taking this series as
is, is not so bad. Esp. since I don't see anyone doing this work
soon.

This comes down to faking the cycling being done inside the firmware/
hardware as e.g. Thinkpads and the Dell XPS series actually do,
so, as said, userspace already needs to deal with this.

If we in the future actually get around to implementing a kbd-illum-cycle
input event and have userspace support in place we can always add the
module option then.

TL;DR: lets just go with this series as is for now, we can always
add a module option to opt-out of handling this in the kernel and
sending a new cycle input event later.

Regards,

Hans