Re: [PATCH v7 2/2] Refactor part of the oom report in dump_header

From: Mike Rapoport
Date: Sun Jun 10 2018 - 01:12:36 EST


On Fri, Jun 08, 2018 at 05:53:14PM +0800, çèé wrote:
> Hi Mike
> > My question was why do you call to alloc_constrained in the dump_header()
> > function rather than pass the constraint that was detected a bit earlier to
> > that function?
>
> dump_header will be called by three functions: oom_kill_process,
> check_panic_on_oom, out_of_memory.
> We can get the constraint from the last two
> functions(check_panic_on_oom, out_of_memory), but I need to
> pass a new parameter(constraint) for oom_kill_process.

Another option is to add the constraint to the oom_control structure.

> Thanks
>

--
Sincerely yours,
Mike.