Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

From: Benjamin Herrenschmidt
Date: Sun Jun 10 2018 - 02:55:53 EST


On Sat, 2018-06-09 at 22:21 +1000, Finn Thain wrote:
> In anycase, the "v1" and "v2" scheme is obviously inadequate when you
> consider the range of m68k powerbook models. Also, consider the
> out-of-tree adaptation of via-pmu by the Nubus-PMac project, which has
> this ABI break:
>
> diff --git a/include/linux/pmu.h b/include/linux/pmu.h
> index cafe98d9694..9882a185a52 100644
> --- a/include/linux/pmu.h
> +++ b/include/linux/pmu.h
> @@ -90,6 +90,7 @@ enum {
> PMU_HEATHROW_BASED, /* PowerBook G3 series */
> PMU_PADDINGTON_BASED, /* 1999 PowerBook G3 */
> PMU_KEYLARGO_BASED, /* Core99 motherboard (PMU99) */
> + PMU_NUBUS_BASED, /* 1400, 2300, 5300 */
> PMU_68K_V1, /* 68K PMU, version 1 */
> PMU_68K_V2, /* 68K PMU, version 2 */
> };
>
> (BTW, these powerbooks are not "nubus based", they are "pre-PCI", so I
> wouldn't want this to go upstream in this form. It could be that
> PMU_NUBUS_BASED should be PMU_UNKNOWN too.)

Pre-PCI is basically "NUBUS" based even in absence of an actual NuBus
slot :-) It has to do with the internal HW architecture. The only ones
that aren't are the even older designs (the 68000 based ones).

What's the situation with those NuBus things ? What do they use as a
bootloader ? The old Apple one or BootX ? We should merge that port of
it's maintained.

Cheers,
Ben.