Re: [PATCH 1/3] livepatch: Nullify obj->mod in klp_module_coming()'s error path

[Petr Mladek]

On Thu 2018-06-07 11:29:47, Miroslav Benes wrote:
> klp_module_coming() is called for every module appearing in the system.
> It sets obj->mod to a patched module for klp_object obj. Unfortunately
> it leaves it set even if an error happens later in the function and the
> patched module is not allowed to be loaded.
> 
> klp_is_object_loaded() uses obj->mod variable and could currently give a
> wrong return value. The bug is probably harmless as of now, but we're
> gonna rely on klp_is_object_loaded() and correct obj->mod much more and
> the bug would be visible then.
> 
> Signed-off-by: Miroslav Benes <mbenes@xxxxxxx>

Great catch!

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr