Re: [PATCH 3/3] module: Remove superfluous call to klp_module_going()

[Jessica Yu]

+++ Miroslav Benes [07/06/18 11:29 +0200]:
> Now that patched modules cannot suddenly disappear we could
> theoretically remove klp_module_going() altogether. Unfortunately we
> cannot do that in practice. Loading of a patched module may fail and we
> need to execute right the actions implemented in klp_module_going().
>
> Remove the call from delete_module syscall though, because that one is
> really superfluous.
>
> Signed-off-by: Miroslav Benes <mbenes@xxxxxxx>

Acked-by: Jessica Yu <jeyu@xxxxxxxxxx>

> ---
> kernel/module.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/module.c b/kernel/module.c
> index a6e43a5806a1..af29a0d3708f 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -1019,7 +1019,6 @@ SYSCALL_DEFINE2(delete_module, const char __user *, name_user,
> 		mod->exit();
> 	blocking_notifier_call_chain(&module_notify_list,
> 				     MODULE_STATE_GOING, mod);
> -	klp_module_going(mod);
> 	ftrace_release_mod(mod);
>
> 	async_synchronize_full();
> --
> 2.17.0