Re: [PATCH V2 1/4] mmc: sdhci-msm: Define new Register address map

[Evan Green]

On Tue, Jun 5, 2018 at 11:31 PM Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
>
> On 29/05/18 12:52, Vijay Viswanath wrote:
> > From: Sayali Lokhande <sayalil@xxxxxxxxxxxxxx>
> >
> > For SDCC version 5.0.0, MCI registers are removed from SDCC
> > interface and some registers are moved to HC.
> > Define a new data structure where we can statically define
> > the address offsets for the registers in different SDCC versions.
> >
> > Signed-off-by: Sayali Lokhande <sayalil@xxxxxxxxxxxxxx>
> > Signed-off-by: Vijay Viswanath <vviswana@xxxxxxxxxxxxxx>
>
> It would be prettier to line up the '=' and use BIT() not << but nevertheless:
>
> Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>

Reviewed-by: Evan Green <evgreen@xxxxxxxxxxxx>