Re: [PATCH v3 6/9] x86: prevent inline distortion by paravirt ops

From: Nadav Amit
Date: Mon Jun 11 2018 - 23:49:47 EST


at 12:45 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Sun, Jun 10, 2018 at 07:19:08AM -0700, Nadav Amit wrote:
>> +/*
>> + * This generates an indirect call based on the operation type number.
>> + * The type number, computed in PARAVIRT_PATCH, is derived from the
>> + * offset into the paravirt_patch_template structure, and can therefore be
>> + * freely converted back into a structure offset.
>> + */
>> +.macro PARAVIRT_ALT type:req clobber:req pv_opptr:req
>
> Unlike the marcro maze you replaced, this has the CALL hardcoded in. So
> maybe name this PARAVIRT_CALL instead of PARAVIRT_ALT ?

Sure. I will also merge the C macros of _paravirt_alt with paravirt_alt
and remove the former.