Re: [PATCH v5 2/3] dt-bindings: usb: new ehci-npcm7xx dt

[Sergei Shtylyov]

Hello!

On 6/11/2018 10:58 PM, avifishman70@xxxxxxxxx wrote:

> From: Avi Fishman <AviFishman70@xxxxxxxxx>
>
> Device Tree documentation for Nuvoton npcm7xx EHCI.
>
> Signed-off-by: Avi Fishman <AviFishman70@xxxxxxxxx>
> Reviewed-by:   Rob Herring <robh@xxxxxxxxxx>
> ---
>   Documentation/devicetree/bindings/usb/npcm7xx-usb.txt | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/usb/npcm7xx-usb.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt b/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt
> new file mode 100644
> index 000000000000..b682bec103f9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt
> @@ -0,0 +1,17 @@
> +Nuvoton NPCM7XX SoC USB controllers:
> +-----------------------------
> +
> +EHCI:
> +-----
> +
> +Required properties:
> +- compatible: "nuvoton,npcm750-ehci"
> +- interrupts: Should contain the EHCI interrupt

   How about "reg"?

> +
> +Example:
> +
> +	ehci1: usb@f0806000 {
> +		compatible = "nuvoton,npcm750-ehci";
> +		reg = <0xf0806000 0x1000>;
> +		interrupts = <0 61 4>;
> +	};

MBR, Sergei