Re: [PATCH v2 10/11] dt-bindings: misc: add bindings for cros_ec_throttler

From: Rob Herring
Date: Tue Jun 12 2018 - 15:10:20 EST


On Thu, Jun 07, 2018 at 11:12:13AM -0700, Matthias Kaehlcke wrote:
> The cros_ec_throttler monitors events from the Chrome OS Embedded
> Controller to throttle the system if needed, using the mechanisms
> provided by the throttler core.
>
> Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> ---
> Changes in v2:
> - patch added to series
>
> Documentation/devicetree/bindings/misc/cros_ec_throttler.txt | 4 ++++
> 1 file changed, 4 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/misc/cros_ec_throttler.txt
>
> diff --git a/Documentation/devicetree/bindings/misc/cros_ec_throttler.txt b/Documentation/devicetree/bindings/misc/cros_ec_throttler.txt
> new file mode 100644
> index 000000000000..7316dcc0ef75
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/cros_ec_throttler.txt
> @@ -0,0 +1,4 @@
> +* cros_ec_throttler driver

Bindings are for h/w, not drivers.

I continue to fail to see why this needs to be in DT. There are other
ways to instantiate drivers.

> +
> +Required properties:
> +- compatible: "google,cros-ec-throttler"
> --
> 2.18.0.rc1.242.g61856ae69a-goog
>