Re: [PATCH 1/7] MIPS: dts: Add aliases node for lantiq danube serial

From: Rob Herring
Date: Tue Jun 12 2018 - 18:24:35 EST


On Tue, Jun 12, 2018 at 01:40:28PM +0800, Songjun Wu wrote:
> Previous implementation uses a hard-coded register value to check if
> the current serial entity is the console entity.
> Now the lantiq serial driver uses the aliases for the index of the
> serial port.
> The lantiq danube serial dts are updated with aliases to support this.
>
> Signed-off-by: Songjun Wu <songjun.wu@xxxxxxxxxxxxxxx>
> ---
>
> arch/mips/boot/dts/lantiq/danube.dtsi | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/lantiq/danube.dtsi b/arch/mips/boot/dts/lantiq/danube.dtsi
> index 2dd950181f8a..7a9e15da6bd0 100644
> --- a/arch/mips/boot/dts/lantiq/danube.dtsi
> +++ b/arch/mips/boot/dts/lantiq/danube.dtsi
> @@ -4,6 +4,10 @@
> #size-cells = <1>;
> compatible = "lantiq,xway", "lantiq,danube";
>
> + aliases {
> + serial0 = &asc1;
> + };
> +
> cpus {
> cpu@0 {
> compatible = "mips,mips24Kc";
> @@ -74,7 +78,7 @@
> reg = <0xE100A00 0x100>;
> };
>
> - serial@E100C00 {
> + asc1: serial@E100C00 {

Fix this to be lower case hex while you are at it.

> compatible = "lantiq,asc";
> reg = <0xE100C00 0x400>;
> interrupt-parent = <&icu0>;
> --
> 2.11.0
>