Re: [RFC PATCH v4 2/8] usb: typec: helper for checking cable plug orientation

[Heikki Krogerus]

On Tue, Jun 12, 2018 at 03:18:42PM -0700, Guenter Roeck wrote:
> On Tue, Jun 12, 2018 at 08:56:31PM +0200, Mats Karrman wrote:
> > Hi Heikki,
> > 
> > On 2018-06-08 13:29, Heikki Krogerus wrote:
> > 
> > >This adds function typec_get_orientation() that can be used
> > >for checking the current cable plug orientation.
> > >
> > >Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> > >---
> > >  drivers/usb/typec/class.c | 11 +++++++++++
> > >  include/linux/usb/typec.h |  1 +
> > >  2 files changed, 12 insertions(+)
> > >
> > >diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> > >index 53df10df2f9d..02db9bcbac0c 100644
> > >--- a/drivers/usb/typec/class.c
> > >+++ b/drivers/usb/typec/class.c
> > >@@ -1279,6 +1279,17 @@ int typec_set_orientation(struct typec_port *port,
> > >  }
> > >  EXPORT_SYMBOL_GPL(typec_set_orientation);
> > >+/**
> > >+ * typec_get_orientation - Get USB Type-C cable plug orientation
> > >+ * @port: USB Type-C Port
> > >+ *
> > >+ * Get current cable plug orientation for @port.
> > >+ */
> > >+enum typec_orientation typec_get_orientation(struct typec_port *port)
> > >+{
> > >+	return port->orientation;
> > >+}
> > 
> > +EXPORT_SYMBOL_GPL(typec_get_orientation);
> > 
> > Isn't this a candidate for an inline?
> > 
> 
> Currently struct typec_port is class private. To make this function inline,
> struct typec_port would have to be moved from drivers/usb/typec/class.c to
> include/linux/usb/typec.h. That doesn't sound like a good idea to me.

Yes, let's keep the structure protected.

But thanks for the report, I'll fix it.


Br,

-- 
heikki