Re: [PATCH] bdi: Fix another oops in wb_workfn()

From: Jan Kara
Date: Wed Jun 13 2018 - 10:46:14 EST


On Wed 13-06-18 19:43:47, Tetsuo Handa wrote:
> Can't we utilize RCU grace period (like shown below) ?

Honestly, the variant 1 looks too ugly to me. However variant 2 looks
mostly OK. We can also avoid the schedule_timeout_uninterruptible(HZ / 10)
from your patch by careful handling of the bit waitqueues. Also I'd avoid
the addition argument to wb_writeback() and split the function instead. The
patch resulting from your and mine ideas is attached. Thoughts?

Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR