Re: [PATCH] perf intel-pt: Fix packet decoding of CYC packets

From: Arnaldo Carvalho de Melo
Date: Wed Jun 13 2018 - 16:02:45 EST


Em Thu, Jun 07, 2018 at 02:30:02PM +0300, Adrian Hunter escreveu:
> Use a 64-bit type so that the cycle count is not limited to 32-bits.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx

Thanks, applied.

- Arnaldo

> ---
> tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c b/tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c
> index ba4c9dd18643..d426761a549d 100644
> --- a/tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c
> +++ b/tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c
> @@ -366,7 +366,7 @@ static int intel_pt_get_cyc(unsigned int byte, const unsigned char *buf,
> if (len < offs)
> return INTEL_PT_NEED_MORE_BYTES;
> byte = buf[offs++];
> - payload |= (byte >> 1) << shift;
> + payload |= ((uint64_t)byte >> 1) << shift;
> }
>
> packet->type = INTEL_PT_CYC;
> --
> 1.9.1