Re: [PATCH v2 1/7] vmw_balloon: fix inflation of 64-bit GFNs
From: Nadav Amit
Date: Thu Jun 14 2018 - 01:41:10 EST
at 10:23 PM, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Jun 13, 2018 at 06:54:06AM -0700, Nadav Amit wrote:
>> When balloon batching is not supported by the hypervisor, the guest
>> frame number (GFN) must fit in 32-bit. However, due to a bug, this check
>> was mistakenly ignored. In practice, when total RAM is greater than
>> 16TB, the balloon does not work currently, making this bug unlikely to
>> Fixes: ef0f8f112984 ("VMware balloon: partially inline vmballoon_reserve_page.")
>> Cc: stable@xxxxxxxxxxxxxxx
> Again, no blank line between these things.
> Also, please break this up into two different patch series. One for
> 4.18-final and one for 4.19-rc1. You should always split up bugfixes
> from new features/cleanups as that is what I have to do when sending
> them to Linus.
I have only sent what I thought is appropriate for 4.18 (cleanup/features
will be sent separately):
* 5 bug fixes (1-5/7)
* 1 update the maintainer list (7/7)
* 1 update to the comment to prevent checkpatch from complaining (6/7)
If you think any patch is unsuitable to 4.18 - please say which.