Re: [PATCH 2/2] gpio: davinci: Do not assume continuous IRQ numbering
From: Linus Walleij
Date: Thu Jun 14 2018 - 04:29:18 EST
On Wed, Jun 6, 2018 at 11:18 AM, Keerthy <j-keerthy@xxxxxx> wrote:
> Currently the driver assumes that the interrupts are continuous
> and does platform_get_irq only once and assumes the rest are continuous,
> instead call platform_get_irq for all the interrupts and store them
> in an array for later use.
>
> Signed-off-by: Keerthy <j-keerthy@xxxxxx>
Hm! Thierry has recently submitted patches to make it easier for chips with
banked IRQs to use the GPIOLIB_IRQCHIP.
Please look at the code in gpio/gpio-tegra186.c and see if you can use
his approach.
As you can see this chip is using gpiochip_irq_map/unmap in its
domain, and manipulates struct gpio_irq_chip directly.
I think the idea is to make it possible to use GPIOLIB_IRQCHIP
for banked IRQs but the infrastructure is not yet inside the gpiolib
so it is a bit taped on the side right now.
Yours,
Linus Walleij