Re: [PATCH v4 2/5] sched/topology: Adding function partition_sched_domains_locked()

[Juri Lelli]

On 14/06/18 09:35, Steven Rostedt wrote:
> On Wed, 13 Jun 2018 14:17:08 +0200
> Juri Lelli <juri.lelli@xxxxxxxxxx> wrote:

[...]

> > +/*
> > + * Call with hotplug lock held
> > + */
> > +void partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
> > +			     struct sched_domain_attr *dattr_new)
> > +{
> > +	lockdep_assert_cpus_held();
> 
> Is the above assert really necessary? The assert will happen in
> partition_sched_domains_locked() anyway.

Indeed, it seems of little use.

Thanks,

- Juri