Re: [PATCH v3] ALSA: sonicvibes: add error handling for snd_ctl_add

From: Takashi Iwai
Date: Thu Jun 14 2018 - 12:00:48 EST


On Thu, 14 Jun 2018 13:41:37 +0200,
Zhouyang Jia wrote:
>
> When snd_ctl_add fails, the lack of error-handling code may
> cause unexpected results.
>
> This patch adds error-handling code after calling snd_ctl_add.
>
> Signed-off-by: Zhouyang Jia <jiazhouyang09@xxxxxxxxx>
> ---
> v1->v2:
> - Check the return value of snd_sonicvibes_create_gameport.
> v2->v3:
> - Fix the code style.

Applied, thanks.


Takashi