Re: [PATCH] proc: Make inline name size calculation automatic

From: Alexey Dobriyan
Date: Thu Jun 14 2018 - 16:10:05 EST


> Require a minimum inline name size of 33+1 to allow for names that look
> like two hex numbers with a dash between.

Hi, David.

Why 34? /proc will fallback to separate allocation for name anyway.

I sent nearly identical patch earlier.
https://marc.info/?l=linux-kernel&m=152667374404900&w=4

If you compare, the differences are:

* no BUILD_BUG_ON,
* 64 bytes is too litle even on 32-bit,
* 512 bytes is probably too much even on 64-bit.

> - .name = proc_root.inline_name,
> - .inline_name = "/proc",
> + .name = "/proc",

This will "uninline" 5 bytes wasting space.