Re: [PATCH v2] dmaengine: rcar-dmac: don't use DMAC error interrupt

From: Kuninori Morimoto
Date: Thu Jun 14 2018 - 20:25:05 EST



Hi Vinod

Thank you for your feedback

> > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> >
> > Current rcar-dmac is using DMAC error interrupt which will handle all
> > channel's error. But in this design, error handling itself will be
> > issue if user want to use virtualization, multi OS, etc.
> > This patch removes current DMAC error interrupt handling, and handle it
> > on each channel interrupt handler.
>
> So what happens when you are not in virtualization, multi OS..? Who
> handles this interrupt?

Sorry for non clear English
It has 2types of interrupt.
1) IRQ for Error
2) IRQ for each channels

If error happens on some channels,
the error IRQ was handled by 1), and "all" channels will be restarted.
Thus, this patch removes 1), and handles each error on 2).

Best regards
---
Kuninori Morimoto