Re: [PATCH v3] dmaengine: rcar-dmac: don't use DMAC error interrupt

From: Geert Uytterhoeven
Date: Fri Jun 15 2018 - 02:20:38 EST

Hi Morimoto-san,

On Fri, Jun 15, 2018 at 2:53 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> rcar-dmac has 2 types of interrupt, 1) error IRQ (for all),
> 2) IRQ for each channels.
> If error happens on some channels, the error IRQ will be handled
> by 1), and "all" channels will be restarted.
> But in this design, error handling itself will be problem for
> non error channel users.
> This patch removes 1) handler, and handles error IRQ on 2)

Thank you, that explains the rationale!

BTW, how can you trigger an error, for testing?

Thanks again!



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds