Re: [PATCH V6] powercap/drivers/idle_injection: Add an idle injection framework
From: Daniel Lezcano
Date: Fri Jun 15 2018 - 04:13:45 EST
On 12/06/2018 19:35, Peter Zijlstra wrote:
[ ... ]
>>>> Yes, drifting is not an issue if that happens. This scheme is simpler
>>>> and safer than setting the timer ahead before waking up the tasks with
>>>> the risk it expires before all the tasks ended their idle cycles.
>>> sloppy though..
>> Ok, do you prefer to see the timer set in the wakeup function and thus
>> having a periodic tick for the idle injection ?
> I think having a HRTIMER_RESTART handler that does hrtimer_forward() is
> the most sensible. You will end up having to deal with threads not being
> ready, but I think that's not a real problem.
Thanks for the restartable timer suggestion. I'm finishing polishing the
code and definitively the result is much more nicer.
<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |