Re: [PATCH v2 1/5] md: Avoid namespace collision with bitmap API
From: Andy Shevchenko
Date: Fri Jun 15 2018 - 10:59:07 EST
On Fri, 2018-06-15 at 23:09 +0800, kbuild test robot wrote:
> Hi Andy,
>
> I love your patch! Yet something to improve:
Thanks!
I fixed that locally (definitely that module wasn't compiled by
default). Though I would wait to gather more comments before sending v3.
>
> [auto build test ERROR on next-20180615]
> [also build test ERROR on v4.17]
> [cannot apply to md/for-next linus/master dm/for-next v4.17 v4.17-rc7
> v4.17-rc6]
> [if your patch is applied to the wrong git tree, please drop us a note
> to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/bitma
> p-Introduce-alloc-free-helpers/20180615-214724
> config: i386-randconfig-b0-06141412 (attached as .config)
> compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
> > > drivers/md/persistent-data/dm-space-map-common.c:111:23: error:
> > > 'bitmap_prepare_for_write' undeclared here (not in a function)
>
> .prepare_for_write = bitmap_prepare_for_write,
> ^
> > > drivers/md/persistent-data/dm-space-map-common.c:112:11: error:
> > > 'bitmap_check' undeclared here (not in a function)
>
> .check = bitmap_check
> ^
> drivers/md/persistent-data/dm-space-map-common.c:72:13: warning:
> 'md_bitmap_prepare_for_write' defined but not used [-Wunused-function]
> static void md_bitmap_prepare_for_write(struct dm_block_validator
> *v,
> ^
> drivers/md/persistent-data/dm-space-map-common.c:84:12: warning:
> 'md_bitmap_check' defined but not used [-Wunused-function]
> static int md_bitmap_check(struct dm_block_validator *v,
> ^
>
> vim +/bitmap_prepare_for_write +111 drivers/md/persistent-data/dm-
> space-map-common.c
>
> 3241b1d3 Joe Thornber 2011-10-31 108
> 3241b1d3 Joe Thornber 2011-10-31 109 static struct
> dm_block_validator dm_sm_bitmap_validator = {
> 3241b1d3 Joe Thornber 2011-10-31 110 .name = "sm_bitmap",
> 3241b1d3 Joe Thornber 2011-10-31 @111 .prepare_for_write =
> bitmap_prepare_for_write,
> 3241b1d3 Joe Thornber 2011-10-31 @112 .check = bitmap_check
> 3241b1d3 Joe Thornber 2011-10-31 113 };
> 3241b1d3 Joe Thornber 2011-10-31 114
>
> :::::: The code at line 111 was first introduced by commit
> :::::: 3241b1d3e0aaafbfcd320f4d71ade629728cc4f4 dm: add persistent
> data library
>
> :::::: TO: Joe Thornber <thornber@xxxxxxxxxx>
> :::::: CC: Alasdair G Kergon <agk@xxxxxxxxxx>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology
> Center
> https://lists.01.org/pipermail/kbuild-all Intel
> Corporation
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy