Re: [PATCH v4 1/2] dt-bindings: cpufreq: Introduce QCOM CPUFREQ FW bindings
From: Sudeep Holla
Date: Fri Jun 15 2018 - 13:42:58 EST
On 15/06/18 18:31, Taniya Das wrote:
>
>
> On 6/15/2018 6:53 PM, Sudeep Holla wrote:
>>
[...]
>>>
>>>> It should be easily extensible is what I am
>>>> trying to say. You can add more info and alter the information in the
>>>> driver with compatibles if you keep the register info as minimum as
>>>> possible. For now, you have enable, set and lut registers. What if you
>>>> want to provide power numbers ?
>>>>
>>>
>>> Yes I do understand the intent of mapping the whole register space, but
>>> as per the HW specs these 3 registers would be the only ones required
>>> for now. I do not think this hardware engine has any information on the
>>> power numbers.
>>>
>>
>> That's fine. So on this platform DT, will you list only the registers
>> touched by the OS for all the IP ? I am sure that will not be the case.
>>
>
> Yes, registers list those would be touched by OS only.
>
You are still missing the point.
Look at other IP blocks like pinmux/gpio/...(choose your pick).
E.g. Lets say gpio controller driver touches only status set and get
registers in a port, will you list then individually in the DT for 'n'
ports on the platform ?
--
Regards,
Sudeep