[PATCH] MIPS: Octeon: add missing of_node_put()
From: Nicholas Mc Guire
Date: Sat Jun 16 2018 - 03:52:48 EST
The call to of_find_node_by_name inside the do-while-loop is returning
node with refcount incremented thus it must be explicitly decremented
here after usage.
Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>
commit 93e502b3c2d4 ("MIPS: OCTEON: Platform support for OCTEON III USB controller")
---
Problem located by an experimental coccinelle script
Patch was compile tested with: cavium_octeon_defconfig (implies
CONFIG_USB=y)
(with a number of sparse warnings - not related to the proposed change)
Patch is against 4.17.0 (localversion-next is next-20180614)
arch/mips/cavium-octeon/octeon-usb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/cavium-octeon/octeon-usb.c b/arch/mips/cavium-octeon/octeon-usb.c
index bfdfaf3..76e06b4 100644
--- a/arch/mips/cavium-octeon/octeon-usb.c
+++ b/arch/mips/cavium-octeon/octeon-usb.c
@@ -512,6 +512,7 @@ static int __init dwc3_octeon_device_init(void)
if (of_device_is_compatible(node, compat_node_name)) {
pdev = of_find_device_by_node(node);
+ of_node_put(node);
if (!pdev)
return -ENODEV;
--
2.1.4