Re: [PATCH v2 1/4] vt: preserve unicode values corresponding to screen characters

From: valdis . kletnieks
Date: Sun Jun 17 2018 - 19:30:45 EST


On Sun, 17 Jun 2018 19:17:51 -0400, Nicolas Pitre said:
> On Sun, 17 Jun 2018, valdis.kletnieks@xxxxxx wrote:

> > This preprocessor variable seems to be dangling in the breeze, with
> > no way for it to get set? As a result, we pick up the #else define by
> > default.
>
> That's actually what's intended here.
>
> If vc_screen.c ever becomes configurable then this could be used to
> compile out this code. Or if someone wants to disable it for some
> debugging reasons. For now it is just a self-explanatory placeholder
> with very little chance of being set by mistake for any other purpose.

Oh, OK. It's code that makes sense if it's intentional - but could just as
easily been an unintended debugging/whatever leftover...

Attachment: pgpkw4Cgipz9F.pgp
Description: PGP signature