Re: [PATCH 4.16 020/279] dt-bindings: net: ravb: Add support for r8a77965 SoC

[Geert Uytterhoeven]

Hi Sergei,

On Mon, Jun 18, 2018 at 10:46 AM Sergei Shtylyov
<sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
> On 6/18/2018 11:10 AM, Greg Kroah-Hartman wrote:
>
> > 4.16-stable review patch.  If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
> >
> > [ Upstream commit 1a862488729a6ea9cfd285d2c90f8738949ae7d2 ]
> >
> > Add documentation for r8a77965 compatible string to renesas ravb device
> > tree bindings documentation.
> >
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> > Acked-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> > Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/net/renesas,ravb.txt |    1 +
> >   1 file changed, 1 insertion(+)
> >
> > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > @@ -17,6 +17,7 @@ Required properties:
> >
> >         - "renesas,etheravb-r8a7795" for the R8A7795 SoC.
> >         - "renesas,etheravb-r8a7796" for the R8A7796 SoC.
> > +      - "renesas,etheravb-r8a77965" for the R8A77965 SoC.
> >         - "renesas,etheravb-r8a77970" for the R8A77970 SoC.
> >         - "renesas,etheravb-r8a77980" for the R8A77980 SoC.
> >         - "renesas,etheravb-r8a77995" for the R8A77995 SoC.
>
>     Seeing the bindings update in -stable for the 1st time, and I highly doubt
> that it's necessary here.

They don't hurt (as long as no _separate_ driver update is needed!), hence
I don't object to backporting in-se.

But their usefulness can be doubted, as they don't change the behavior of the
kernel, unlikely adding e.g. new PCI IDs, or extending drivers with
new compatible
values. It's purely a documentation update.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds