Re: [PATCH 4/7] tty: serial: lantiq: Always use readl()/writel()
From: Wu, Songjun
Date: Mon Jun 18 2018 - 05:40:05 EST
On 6/14/2018 6:07 PM, Arnd Bergmann wrote:
On Tue, Jun 12, 2018 at 7:40 AM, Songjun Wu <songjun.wu@xxxxxxxxxxxxxxx> wrote:
Previous implementation uses platform-dependent functions
ltq_w32()/ltq_r32() to access registers. Those functions are not
available for other SoC which uses the same IP.
Change to OS provided readl()/writel() and readb()/writeb(), so
that different SoCs can use the same driver.
Signed-off-by: Songjun Wu <songjun.wu@xxxxxxxxxxxxxxx>
Are there any big-endian machines using this driver? The original definition
of ltq_r32() uses non-byteswapping __raw_readl() etc, which suggests
that the registers might be wired up in a way that matches the CPU
endianess (this is usally a bad idea in hardware design, but nothing
we can influence in the OS).
When you change it to readl(), that will breaks all machines that rely
on the old behavior on big-endian kernels.
Arnd
It will not break existing big-endian SoC as SWAP_IO_SPACE is disabled.
Disable SWAP_IO_SPACE will not impact ltq_r32 as it uses non-byte
swapping __raw_readl() and it makes readl work in big-endian kernel too.
The old Lantiq platform enable SWAP_IO_SPACE to support PCI as it's a
little-endian bus plus PCI TX/RX swap enable impacted both data and
control path.
Alternatively PCI device driver has to do endian swap, It is better to
let PCI device driver to do endian swap instead because SWAP_IO_SPACE is
global wide macro.
Once we set it, other peripheral such as USB has to change its register
access as well