Re: [PATCH v2] char: agp: Change return type to vm_fault_t

[Souptick Joarder]

On Thu, May 31, 2018 at 10:38 AM, Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
> On Mon, May 21, 2018 at 11:47 PM, Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
>> Use new return type vm_fault_t for fault handler. For now,
>> this is just documenting that the function returns a
>> VM_FAULT value rather than an errno. Once all instances are
>> converted, vm_fault_t will become a distinct type.
>>
>> Ref-> commit 1c8f422059ae ("mm: change return type to
>> vm_fault_t") was added in 4.17-rc1 to introduce the new
>> typedef vm_fault_t. Currently we are making change to all
>> drivers to return vm_fault_t for page fault handlers. As
>> part of that char/agp driver is also getting changed to
>> return vm_fault_t type from fault handler.
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
>> Reviewed-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
>> ---
>>  drivers/char/agp/alpha-agp.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/char/agp/alpha-agp.c b/drivers/char/agp/alpha-agp.c
>> index 53fe633..c9bf2c2 100644
>> --- a/drivers/char/agp/alpha-agp.c
>> +++ b/drivers/char/agp/alpha-agp.c
>> @@ -11,7 +11,7 @@
>>
>>  #include "agp.h"
>>
>> -static int alpha_core_agp_vm_fault(struct vm_fault *vmf)
>> +static vm_fault_t alpha_core_agp_vm_fault(struct vm_fault *vmf)
>>  {
>>         alpha_agp_info *agp = agp_bridge->dev_private_data;
>>         dma_addr_t dma_addr;
>> --
>> 1.9.1
>>
>
> Any comment for this patch ?

Any further comment on this patch ?