Re: [PATCH] staging: fbtft: Add missing blank line after function definition

From: Greg KH
Date: Mon Jun 18 2018 - 07:45:37 EST


On Mon, Jun 18, 2018 at 04:57:41PM +0530, Jay Buddhabhatti wrote:
> Reslove checkpatch warnings by adding missing blank line after
> function definition.
>
> Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@xxxxxxxxxxxxxxx>
> ---
> drivers/staging/fbtft/fb_s6d1121.c | 1 +
> drivers/staging/fbtft/fb_ssd1289.c | 1 +
> drivers/staging/fbtft/fb_st7735r.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/drivers/staging/fbtft/fb_s6d1121.c b/drivers/staging/fbtft/fb_s6d1121.c
> index b902442..b0c7a77 100644
> --- a/drivers/staging/fbtft/fb_s6d1121.c
> +++ b/drivers/staging/fbtft/fb_s6d1121.c
> @@ -154,6 +154,7 @@ static int set_gamma(struct fbtft_par *par, u32 *curves)
>
> return 0;
> }
> +
> #undef CURVE
>
> static struct fbtft_display display = {

There already is a blank line here, no need to add another one. Looks
like checkpatch.pl is being a bit too over-eager here, sorry.

thanks,

greg k-h