Re: [PATCH v4] platform/x86: touchscreen_dmi: Add info for the ONDA V891W Dual OS tablet
From: Andy Shevchenko
Date: Mon Jun 18 2018 - 09:59:39 EST
+Cc: Stephen
On Mon, Jun 18, 2018 at 3:54 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> Hi,
>
> On 18-06-18 10:43, Hans de Goede wrote:
>>
>> Hi,
>>
>> On 18-06-18 01:58, youling257 wrote:
>>>
>>> Add touchscreen info for the ONDA V891W Dual OS tablet
>>
>>
>> Nitpick: still missing a period '.' at the end, this should be:
>>
>> Add touchscreen info for the ONDA V891W Dual OS tablet.
>>
>>> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>>> Signed-off-by: youling257 <youling257@xxxxxxxxx>
>>
>>
>> As Andy indicated you need to use your real name when submitting
>> kernel patches, not an internet alias (or a nick).
>>
>> So you need to re-submit this with something like this:
>>
>> Signed-off-by: FirstName LastName <youling257@xxxxxxxxx>
>
>
> youling has indicated to me (off-list) that he does not
> want to use his real name.
>
> He has already provided me with the touchscreen details
> and dmi strings for this tablet a while ago and I had
> writing the exact same quirk on my TODO list already.
>
> As such I've no doubt that he created this patch and
> has the rights to Submit it under the GPL license.
>
> So I'm going to resubmit this with his S-o-b removed
> and replaced with mine. Where the intent of my
> S-o-b is to certify point c. of the certificate
> of origin, quoting from:
>
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
>
> "c. The contribution was provided directly to me by some other person who
> certified (a), (b) or (c) and I have not modified it."
>
> This seems better then me re-creating the exact
> same patch from scratch.
I guess this will not pass checks Stephen has.
So, Stephen, how should we proceed?
--
With Best Regards,
Andy Shevchenko