Re: [PATCH] crypto: skcipher: remove static declaration of export function

[Eric Biggers]

On Sun, Jun 17, 2018 at 08:49:59PM +0300, efremov@xxxxxxxxx wrote:
> The function skcipher_walk_next declared as static and marked as
> EXPORT_SYMBOL. It's a bit confusing since export symbol means that
> we want others to use this function. The area of visibility for such
> function is its .c file and all other modules. Other *.c files of the
> same module can't use it, despite all other modules can. Relying on
> that such behavior was not the original intention, the patch just
> removes the static keyword.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Denis Efremov <efremov@xxxxxxxxx>

Why not remove the EXPORT_SYMBOL instead?  It has no users outside the file.

- Eric