Re: [PATCH 4.14 102/189] scsi: vmw-pvscsi: return DID_BUS_BUSY for adapter-initated aborts

From: Jim Gill
Date: Mon Jun 18 2018 - 14:32:53 EST


Fine by me.




On 6/18/18, 1:13 AM, "Greg Kroah-Hartman" <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

>4.14-stable review patch. If anyone has any objections, please let me know.
>
>------------------
>
>From: Jim Gill <jgill@xxxxxxxxxx>
>
>[ Upstream commit f4b024271ae3e9786e5d6f1c05b01b57a74e1d6d ]
>
>The vmw_pvscsi driver returns DID_ABORT for commands aborted internally
>by the adapter, leading to the filesystem going read-only. Change the
>result to DID_BUS_BUSY, causing the kernel to retry the command.
>
>Signed-off-by: Jim Gill <jgill@xxxxxxxxxx>
>Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
>Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxxxx>
>Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>---
> drivers/scsi/vmw_pvscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>--- a/drivers/scsi/vmw_pvscsi.c
>+++ b/drivers/scsi/vmw_pvscsi.c
>@@ -609,7 +609,7 @@ static void pvscsi_complete_request(stru
> break;
>
> case BTSTAT_ABORTQUEUE:
>- cmd->result = (DID_ABORT << 16);
>+ cmd->result = (DID_BUS_BUSY << 16);
> break;
>
> case BTSTAT_SCSIPARITY:
>
>