Re: [PATCHv3 00/18] atomics: API cleanups

[Mark Rutland]

On Mon, Jun 18, 2018 at 05:38:06PM +0100, Will Deacon wrote:
> On Mon, Jun 18, 2018 at 11:19:01AM +0100, Mark Rutland wrote:
> > This series contains a few cleanups of the atomic API, fixing
> > inconsistencies between atomic_* and atomic64_*, and minimizing
> > repetition in arch code. This is nicer for arch code, and the improved
> > regularity will help when generating the atomic headers in future.
> 
> Apart from the Alpha patch:
> 
> Reviewed-by: Will Deacon <will.deacon@xxxxxxx>

Cheers! I assume that also holds with patch 7 fixes up to use s64.

> I also tried to compare disassembly before/after, but the changes to
> add_unless made that quite fiddly for anything using it as a backend.
> 
> Do you plan to move arm64 over to atomic-instrumented.h at some point?

That's the plan -- there's still a way to go with the generated atomic headers
for that to work.

Thanks,
Mark.