Re: [RESEND PATCH v12 2/2] sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq()

From: Steven Rostedt
Date: Mon Jun 18 2018 - 17:42:10 EST


On Mon, 18 Jun 2018 13:58:09 +0900
Byungchul Park <byungchul.park@xxxxxxx> wrote:

> Hello Steven,
>
> I've changed the code a little bit to avoid a compile warning caused by
> 'const' args of find_cpu(). Can I keep your Reviewed-by?
>
> BEFORE:
> static int find_cpu(const struct cpumask *mask,
> const struct sched_domain *sd,
> const struct sched_domain *prefer)
>
> AFTER:
> static int find_cpu(const struct cpumask *mask,
> struct sched_domain *sd,
> struct sched_domain *prefer)
>
> (I temporarily removed the Reviewed-by you gave me.)
> Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

I would fix sched_domain_span() to take a constant and keep the
previous patch.

-- Steve