Re: [PATCH] misc: ocxl: Change return type for fault handler

From: Michael Ellerman
Date: Tue Jun 19 2018 - 08:57:31 EST


Souptick Joarder <jrdr.linux@xxxxxxxxx> writes:
> On Thu, Jun 14, 2018 at 9:36 PM, Frederic Barrat <fbarrat@xxxxxxxxxxxxx> wrote:
>> Le 11/06/2018 Ã 22:29, Souptick Joarder a Ãcrit :
>>>
>>> Use new return type vm_fault_t for fault handler. For
>>> now, this is just documenting that the function returns
>>> a VM_FAULT value rather than an errno. Once all instances
>>> are converted, vm_fault_t will become a distinct type.
>>>
>>> Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t")
>>>
>>> There is an existing bug when vm_insert_pfn() can return
>>> ENOMEM which was ignored and VM_FAULT_NOPAGE returned as
>>> default. The new inline vmf_insert_pfn() has removed
>>> this inefficiency by returning correct vm_fault_ type.
>>>
>>> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
>>> ---
>>
>>
>> Thanks!
>>
>> Tested and
>> Acked-by: Frederic Barrat <fbarrat@xxxxxxxxxxxxxxxxxx>
>
> Frederic, is this patch queued for 4.19 ?

Not yet, you're a bit early. 4.18-rc1 only came out the other day :)

Your patches are tracked here:

http://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=67924


They should appear in 4.19 unless something conflicts with them.

cheers