Re: linux-next: manual merge of the vfs tree with the overlayfs tree

From: Miklos Szeredi
Date: Tue Jun 19 2018 - 09:38:11 EST


On Tue, Jun 19, 2018 at 10:40 AM, David Howells <dhowells@xxxxxxxxxx> wrote:
> Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
>> /* These sb flags are internal to the kernel */
>> #define MS_SUBMOUNT (1<<26)
>> -#define MS_NOREMOTELOCK (1<<27)
>> #define MS_NOSEC (1<<28)
>> #define MS_BORN (1<<29)
>> #define MS_ACTIVE (1<<30)
>
> Ummm... Can MS_NOREMOTELOCK be removed? I know it's listed in the internal
> flags section, but all of these have been exposed to userspace for over a
> year. Ideally, I'd remove all of these from UAPI, but can anyone guarantee
> that no pieces of userspace refer to them?

The number of potential users of these flags is pretty low, so I think
we can try and remove them and hope nothing breaks.

Probably best left after the dust settles.

Thanks,
Miklos