Re: [PATCH v2 0/2] Detect & register virtio-crypto algos only if it can be supported by backend

[Christian Borntraeger]

On 06/19/2018 03:26 PM, Farhan Ali wrote:
> A polite ping :)
> 
> If no one has any more comments/feedback then I would like to how to merge these patches to the mainline kernel tree.

I think it should go via Michael Tsirkin or Jason Wang (Adding Jason).
Also adding Herbert Xu as FYI.


I have not looked into the details of the patch, but I like the idea.
Acked-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>



> 
> Thanks
> Farhan
> 
> On 06/13/2018 04:38 PM, Farhan Ali wrote:
>> Hi,
>>
>> Currently the Linux virtio-crypto driver registers the crypto
>> algorithm without verifying if the backend actually supports the
>> algorithm.
>>
>> This kernel patch series adds support for registering algorithm
>> with Linux crypto layer, only if the algorithm is supported by
>> the backend device. This also makes the driver more compliant with
>> the virtio-crypto spec [1].
>>
>> I would appreciate any feedback or comments on this.
>>
>> Thank you
>> Farhan
>>
>> Reference
>> ---------
>> [1] Virtio crypto spec proposal https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg00816.html
>>
>> ChangeLog
>> ---------
>> v1 -> v2
>> ÂÂÂ - Modify comment as suggested by Arei (patch 1)
>> ÂÂÂ - Modify error message as suggested by Arei (patch 2)
>>
>>
>> Farhan Ali (2):
>> ÂÂ crypto/virtio-crypto: Read crypto services and algorithm masks
>> ÂÂ crypto/virtio-crypto: Register an algo only if it's supported
>>
>> Â drivers/crypto/virtio/virtio_crypto_algs.cÂÂ | 112 ++++++++++++++++++---------
>> Â drivers/crypto/virtio/virtio_crypto_common.h |Â 25 +++++-
>> Â drivers/crypto/virtio/virtio_crypto_core.cÂÂ |Â 29 +++++++
>> Â drivers/crypto/virtio/virtio_crypto_mgr.cÂÂÂ |Â 81 +++++++++++++++++--
>> Â 4 files changed, 202 insertions(+), 45 deletions(-)
>>
>